Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.1.7 #103

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Rc 1.1.7 #103

merged 3 commits into from
Nov 9, 2024

Conversation

semuadmin
Copy link
Contributor

pygnssutils Pull Request Template

Description

  1. gnssntripclient will now tolerate an NTRIP 1.0 response to an NTRIP 2.0 request if the caster only supports NTRIP 1.0, or vice versa.
  2. gnssstreamer now supports both NTRIP 1.0 and NTRIP 2.0 clients via the -rtkntripversion flag (previously it assumed NTRIP 2.0).

Fixes #102

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Tested for range of NTRIP 1.0 and NTRIP 2.0 casters.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the enhancement New feature or request label Nov 4, 2024
@semuadmin semuadmin added this to the RC 1.1.7 milestone Nov 4, 2024
@semuadmin semuadmin self-assigned this Nov 4, 2024
@semuadmin semuadmin marked this pull request as draft November 4, 2024 23:14
@semuadmin semuadmin marked this pull request as ready for review November 9, 2024 13:33
@semuadmin semuadmin requested a review from a team November 9, 2024 13:35
@semuadmin semuadmin merged commit 7ecbcf5 into main Nov 9, 2024
@semuadmin semuadmin deleted the RC-1.1.7 branch November 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants